https://codereview.chromium.org/809333002/diff/130001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/809333002/diff/130001/src/compiler/instruction-selector.cc#newcode467
src/compiler/instruction-selector.cc:467: // TODO(turbofan): only
reverse if > 1 instruction emitted.
std::reverse handles that efficiently. No need to duplicate the work in
our code. Remove this TODO.
https://codereview.chromium.org/809333002/diff/130001/src/compiler/instruction-selector.cc#newcode688
src/compiler/instruction-selector.cc:688: return VisitOsrValue(node);
Missing MarkAsReference(node) here.
https://codereview.chromium.org/809333002/diff/130001/src/compiler/osr.h
File src/compiler/osr.h (right):
https://codereview.chromium.org/809333002/diff/130001/src/compiler/osr.h#newcode78
src/compiler/osr.h:78: // an outer loop).
Nice explanation!
https://codereview.chromium.org/809333002/diff/130001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/809333002/diff/130001/src/compiler/pipeline.cc#newcode863
src/compiler/pipeline.cc:863: Run<OsrDeconstructionPhase>();
Hm, can't we make the OSR deconstruction part of the late control
reduction?
https://codereview.chromium.org/809333002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
