Reviewers: Toon Verwaest,

Message:
PTAL.


https://codereview.chromium.org/856503002/diff/20001/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/856503002/diff/20001/src/mirror-debugger.js#newcode184
src/mirror-debugger.js:184: PropertyType.DataConstant                =
2;
This should have been fixed earlier.

Description:
Massive renaming of PropertyType values and other implied stuff.

PropertyType:
  FIELD -> DATA_FIELD
  CONSTANT -> DATA_CONSTANT
  CALLBACKS -> ACCESSOR_CONSTANT

PropertyLocation:
  IN_OBJECT -> FIELD
  IN_DESCRIPTOR -> DESCRIPTOR

StoreMode:
  FORCE_IN_OBJECT -> FORCE_FIELD

FieldDescriptor -> DataFieldDescriptor
ConstantDescriptor -> DataConstantDescriptor
CallbacksDescriptor -> AccessorConstantDescriptor


Please review this at https://codereview.chromium.org/856503002/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+412, -389 lines):
  M src/bootstrapper.cc
  M src/elements.cc
  M src/factory.cc
  M src/heap-snapshot-generator.cc
  M src/hydrogen.h
  M src/hydrogen.cc
  M src/ic/handler-compiler.cc
  M src/ic/ic.cc
  M src/json-stringifier.h
  M src/layout-descriptor-inl.h
  M src/lookup.h
  M src/lookup.cc
  M src/mirror-debugger.js
  M src/objects.h
  M src/objects.cc
  M src/objects-debug.cc
  M src/objects-inl.h
  M src/objects-printer.cc
  M src/property.h
  M src/property.cc
  M src/property-details.h
  M src/runtime/runtime.cc
  M src/runtime/runtime-debug.cc
  M src/runtime/runtime-object.cc
  M src/runtime/runtime-scopes.cc
  M src/string-stream.cc
  M src/transitions.cc
  M test/cctest/test-alloc.cc
  M test/cctest/test-transitions.cc
  M test/cctest/test-unboxed-doubles.cc
  M test/mjsunit/mirror-object.js
  M test/mjsunit/regress/regress-merge-descriptors.js


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to