Reviewers: jarin,
Message:
PTAL. Note that this also removes --turbo-asm from the TurboFan variant
because
it is enabled by default now.
Description:
Enable test coverage for --turbo-deoptimization mode.
[email protected]
Please review this at https://codereview.chromium.org/845193004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+15, -63 lines):
M test/benchmarks/testcfg.py
M test/cctest/cctest.status
M test/mjsunit/mjsunit.status
M test/unittests/compiler/js-operator-unittest.cc
M tools/testrunner/local/testsuite.py
Index: test/benchmarks/testcfg.py
diff --git a/test/benchmarks/testcfg.py b/test/benchmarks/testcfg.py
index
29e0c37e44f68df83393c1bcef379df7dccd19fd..6607bef8cc68bc51c80e088a40bd32d069a2da4d
100644
--- a/test/benchmarks/testcfg.py
+++ b/test/benchmarks/testcfg.py
@@ -186,7 +186,7 @@ class BenchmarksTestSuite(testsuite.TestSuite):
# Both --nocrankshaft and --stressopt are very slow. Add TF but without
# always opt to match the way the benchmarks are run for performance
# testing.
- return [[], ["--turbo-asm", "--turbo-filter=*"]]
+ return [[], ["--turbo-filter=*"]]
def GetSuite(name, root):
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
cc5414da27364e4955eaf8abd8f48de8f65121a3..daf88415467db8de3f196da796c07d8298df19da
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -90,29 +90,12 @@
# BUG(3742).
'test-mark-compact/MarkCompactCollector': [PASS, ['arch==arm',
NO_VARIANTS]],
- # Support for %GetFrameDetails is missing and requires checkpoints.
- 'test-api/Regress385349': [PASS, NO_VARIANTS],
- 'test-debug/DebuggerStatement': [PASS, NO_VARIANTS],
- 'test-debug/DebuggerStatementBreakpoint': [PASS, NO_VARIANTS],
- 'test-debug/DebugEvaluateWithCodeGenerationDisallowed': [PASS,
NO_VARIANTS],
- 'test-debug/DebugStepNatives': [PASS, NO_VARIANTS],
- 'test-debug/DebugStepFunctionCall': [PASS, NO_VARIANTS],
- 'test-debug/DebugStepFunctionApply': [PASS, NO_VARIANTS],
- 'test-debug/ScriptNameAndData': [PASS, NO_VARIANTS],
- 'test-debug/ContextData': [PASS, NO_VARIANTS],
- 'test-debug/DebugBreakInMessageHandler': [PASS, NO_VARIANTS],
- 'test-debug/CallFunctionInDebugger': [PASS, NO_VARIANTS],
- 'test-debug/CallingContextIsNotDebugContext': [PASS, NO_VARIANTS],
- 'test-debug/DebugEventContext': [PASS, NO_VARIANTS],
- 'test-debug/DebugBreakInline': [PASS, NO_VARIANTS],
- 'test-debug/BreakMessageWhenMessageHandlerIsReset': [PASS, NO_VARIANTS],
- 'test-debug/DebugBreak': [PASS, NO_VARIANTS],
- 'test-debug/DebugBreakFunctionApply': [PASS, NO_VARIANTS],
- 'test-debug/DebugBreakStackInspection': [PASS, NO_VARIANTS],
- 'test-debug/DeoptimizeDuringDebugBreak': [PASS, NO_VARIANTS],
- 'test-debug/DisableBreak': [PASS, NO_VARIANTS],
- 'test-debug/NoDebugBreakInAfterCompileMessageHandler': [PASS,
NO_VARIANTS],
- 'test-debug/RegExpDebugBreak': [PASS, NO_VARIANTS],
+ # TODO(jarin): Some tests don't like --turbo-deoptimzation very much.
+ 'test-api/ApiUncaughtExceptionInObjectObserve': [PASS, NO_VARIANTS],
+ 'test-api/GetPrototypeAccessControl': [PASS, NO_VARIANTS],
+ 'test-api/Regress93759': [PASS, NO_VARIANTS],
+ 'test-debug/DebugBreakOnExceptionInObserveCallback': [PASS, NO_VARIANTS],
+ 'test-object-observe/DeliveryCallbackThrows': [PASS, NO_VARIANTS],
# TODO(titzer): Triggers bug in late control reduction.
'test-run-inlining/InlineLoopGuardedEmpty': [SKIP],
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
2e769277106e315a24b657007d10837740853092..1761fb34e8be0fda20a2b684b0040751f3b4a935
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -76,49 +76,18 @@
'whitespaces': [PASS, NO_VARIANTS],
'compiler/osr-assert': [PASS, NO_VARIANTS],
'regress/regress-2185-2': [PASS, NO_VARIANTS],
+ 'regress/regress-2612': [PASS, NO_VARIANTS],
# Issue 3660: Replacing activated TurboFan frames by unoptimized code
does
# not work, but we expect it to not crash.
'debug-step-turbofan': [PASS, FAIL],
- # Support for %GetFrameDetails is missing and requires checkpoints.
- 'debug-evaluate-bool-constructor': [PASS, NO_VARIANTS],
- 'debug-evaluate-const': [PASS, NO_VARIANTS],
- 'debug-evaluate-locals-optimized-double': [PASS, NO_VARIANTS],
- 'debug-evaluate-locals-optimized': [PASS, NO_VARIANTS],
- 'debug-evaluate-locals': [PASS, NO_VARIANTS],
- 'debug-evaluate-with-context': [PASS, NO_VARIANTS],
- 'debug-liveedit-double-call': [PASS, NO_VARIANTS],
- 'debug-liveedit-restart-frame': [PASS, NO_VARIANTS],
- 'debug-return-value': [PASS, NO_VARIANTS],
- 'debug-set-variable-value': [PASS, NO_VARIANTS],
- 'debug-step-stub-callfunction': [PASS, NO_VARIANTS],
- 'debug-stepin-accessor': [PASS, NO_VARIANTS],
- 'debug-stepin-builtin': [PASS, NO_VARIANTS],
- 'debug-stepin-constructor': [PASS, NO_VARIANTS],
- 'debug-stepin-function-call': [PASS, NO_VARIANTS],
- 'debug-stepnext-do-while': [PASS, NO_VARIANTS],
- 'debug-stepout-recursive-function': [PASS, NO_VARIANTS],
- 'debug-stepout-scope-part1': [PASS, NO_VARIANTS],
- 'debug-stepout-scope-part2': [PASS, NO_VARIANTS],
- 'debug-stepout-scope-part3': [PASS, NO_VARIANTS],
- 'debug-stepout-scope-part7': [PASS, NO_VARIANTS],
- 'debug-stepout-to-builtin': [PASS, NO_VARIANTS],
- 'es6/debug-promises/throw-in-constructor': [PASS, NO_VARIANTS],
- 'es6/debug-promises/reject-in-constructor': [PASS, NO_VARIANTS],
- 'es6/debug-promises/throw-with-undefined-reject': [PASS, NO_VARIANTS],
- 'es6/debug-promises/throw-with-throw-in-reject': [PASS, NO_VARIANTS],
- 'es6/debug-promises/reject-with-throw-in-reject': [PASS, NO_VARIANTS],
- 'es6/debug-promises/throw-uncaught-all': [PASS, NO_VARIANTS],
- 'es6/debug-promises/throw-uncaught-uncaught': [PASS, NO_VARIANTS],
- 'es6/debug-promises/reject-uncaught-late': [PASS, NO_VARIANTS],
- 'es6/debug-promises/throw-caught-by-default-reject-handler': [PASS,
NO_VARIANTS],
- 'es6/generators-debug-scopes': [PASS, NO_VARIANTS],
- 'harmony/debug-blockscopes': [PASS, NO_VARIANTS],
- 'regress/regress-1081309': [PASS, NO_VARIANTS],
- 'regress/regress-269': [PASS, NO_VARIANTS],
+ # TODO(jarin): Some tests don't like --turbo-deoptimzation very much.
+ 'asm/embenchen/lua_binarytrees': [PASS, NO_VARIANTS],
+ 'es6/symbols': [PASS, NO_VARIANTS],
+ 'es7/object-observe-debug-event': [PASS, NO_VARIANTS],
+ 'harmony/classes': [PASS, NO_VARIANTS],
'regress/regress-crbug-259300': [PASS, NO_VARIANTS],
- 'regress/regress-frame-details-null-receiver': [PASS, NO_VARIANTS],
# TODO(arv): TurboFan does not yet add [[HomeObject]] as needed.
'harmony/object-literals-super': [PASS, NO_VARIANTS],
Index: test/unittests/compiler/js-operator-unittest.cc
diff --git a/test/unittests/compiler/js-operator-unittest.cc
b/test/unittests/compiler/js-operator-unittest.cc
index
7aa0c6447a731db53c7bd4279bafbbfb674ae1b7..912f98430d3034592f4e5682dd3a8e8401a486b7
100644
--- a/test/unittests/compiler/js-operator-unittest.cc
+++ b/test/unittests/compiler/js-operator-unittest.cc
@@ -66,7 +66,7 @@ const SharedOperator kSharedOperators[] = {
SHARED(Modulus, Operator::kNoProperties, 2, 1, 1, 1, 1, 1),
SHARED(UnaryNot, Operator::kPure, 1, 0, 0, 0, 1, 0),
SHARED(ToBoolean, Operator::kPure, 1, 0, 0, 0, 1, 0),
- SHARED(ToNumber, Operator::kNoProperties, 1, 0, 1, 1, 1, 1),
+ SHARED(ToNumber, Operator::kNoProperties, 1, 1, 1, 1, 1, 1),
SHARED(ToString, Operator::kNoProperties, 1, 0, 1, 1, 1, 1),
SHARED(ToName, Operator::kNoProperties, 1, 0, 1, 1, 1, 1),
SHARED(ToObject, Operator::kNoProperties, 1, 1, 1, 1, 1, 1),
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py
b/tools/testrunner/local/testsuite.py
index
84f07feefbca263ecb8fd342f8f6b18689f700c0..f3178d87e189e73faea93c7d587b7da21258c34d
100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -38,7 +38,7 @@ from ..objects import testcase
VARIANT_FLAGS = {
"default": [],
"stress": ["--stress-opt", "--always-opt"],
- "turbofan": ["--turbo-asm", "--turbo-filter=*", "--always-opt"],
+ "turbofan":
["--turbo-deoptimization", "--turbo-filter=*", "--always-opt"],
"nocrankshaft": ["--nocrankshaft"]}
FAST_VARIANT_FLAGS = [
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
