The TurboFan part looks OK to me, didn't look at the rest. To answer your
question: The runtime call you added is wired into the graph in two ways.
1) Implicitly through an effect-dependency, this is done implicitly by
GraphBuilder::NewNode() as you suspected. Every runtime call produces an
"effect" that subsequent nodes will then depend on.
2) The call to BuildVariableAssignment() either simulates a store to a
stack-allocated variable and keeps track of the node in
GraphBuilder::Environment or it actually produces a JSStoreContext node for
context-allocated variables.
In general nodes in the graph are only alive if they are reachable
from "end"
somehow. If some nodes turn out not to be reachable from "end" then they
just
fall off the graph and that is working as intended.
https://codereview.chromium.org/816913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
