https://codereview.chromium.org/883823002/diff/60001/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/883823002/diff/60001/src/ast.h#newcode1696
src/ast.h:1696: VariableProxy(AstValueFactory *ast_value_factory,
On 2015/02/05 11:08:30, wingo wrote:
Humm, seems to me that passing in the factory is not quite right --
the
VariableProxy doesn't need to create values, just check if the value
is "this"
or not.  How about going back to what it was, but replacing the "bool
is_this"
with Variable::Kind variable_kind.

Acknowledged.

https://codereview.chromium.org/883823002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to