Reviewers: Weiliang, danno,
Message:
PTAL.
thanks
Description:
X87: Remove the dependency of Zone on Isolate
port c7b09aac317dd810d29b82061973199b80363b65 (r26252)
original commit message:
Along the way:
- Thread isolate parameter explicitly through code that used to
rely on getting it from the zone.
- Canonicalize the parameter position of isolate and zone for
affected code
- Change Hydrogen New<> instruction templates to automatically
pass isolate
BUG=
Please review this at https://codereview.chromium.org/903183003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -7 lines):
M src/x87/regexp-macro-assembler-x87.h
M src/x87/regexp-macro-assembler-x87.cc
Index: src/x87/regexp-macro-assembler-x87.cc
diff --git a/src/x87/regexp-macro-assembler-x87.cc
b/src/x87/regexp-macro-assembler-x87.cc
index
9bd08caa2ac4567be4e9aa5dc02f0a3862d677f0..cc3f34e4207f8ca53f03f76ba72317450b5513e8
100644
--- a/src/x87/regexp-macro-assembler-x87.cc
+++ b/src/x87/regexp-macro-assembler-x87.cc
@@ -77,12 +77,11 @@ namespace internal {
#define __ ACCESS_MASM(masm_)
-RegExpMacroAssemblerX87::RegExpMacroAssemblerX87(
- Mode mode,
- int registers_to_save,
- Zone* zone)
- : NativeRegExpMacroAssembler(zone),
- masm_(new MacroAssembler(zone->isolate(), NULL, kRegExpCodeSize)),
+RegExpMacroAssemblerX87::RegExpMacroAssemblerX87(Isolate* isolate, Zone*
zone,
+ Mode mode,
+ int registers_to_save)
+ : NativeRegExpMacroAssembler(isolate, zone),
+ masm_(new MacroAssembler(isolate, NULL, kRegExpCodeSize)),
mode_(mode),
num_registers_(registers_to_save),
num_saved_registers_(registers_to_save),
Index: src/x87/regexp-macro-assembler-x87.h
diff --git a/src/x87/regexp-macro-assembler-x87.h
b/src/x87/regexp-macro-assembler-x87.h
index
3655bd9626438b4acad0c2b1ff91980f7e976dd9..f8932627040b36fb87858d89185001ddcf61313f
100644
--- a/src/x87/regexp-macro-assembler-x87.h
+++ b/src/x87/regexp-macro-assembler-x87.h
@@ -15,7 +15,8 @@ namespace internal {
#ifndef V8_INTERPRETED_REGEXP
class RegExpMacroAssemblerX87: public NativeRegExpMacroAssembler {
public:
- RegExpMacroAssemblerX87(Mode mode, int registers_to_save, Zone* zone);
+ RegExpMacroAssemblerX87(Isolate* isolate, Zone* zone, Mode mode,
+ int registers_to_save);
virtual ~RegExpMacroAssemblerX87();
virtual int stack_limit_slack();
virtual void AdvanceCurrentPosition(int by);
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
