https://codereview.chromium.org/934463003/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/934463003/diff/60001/src/objects.cc#newcode12884
src/objects.cc:12884: // is read-only (a declared const that has not
been initialized). If a
On 2015/02/17 22:47:45, adamk wrote:
Is this comment still providing value?
I believe this is still the case. If there is a non-configurable,
non-writable property we still redefine it.
https://codereview.chromium.org/934463003/diff/60001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/934463003/diff/60001/test/mjsunit/harmony/super.js#newcode1413
test/mjsunit/harmony/super.js:1413: // TODO(arv): This is broken
On 2015/02/17 22:47:45, adamk wrote:
Is this a stray TODO?
Done.
https://codereview.chromium.org/934463003/diff/60001/test/mjsunit/harmony/super.js#newcode1414
test/mjsunit/harmony/super.js:1414: (function
TestKeyedNumericSetterCreatingOwnProperties() {
On 2015/02/17 22:47:45, adamk wrote:
Is there any reason this test needs to duplicate all of the code in
the keyed
named property version? I'd think you could re-use exactly the same
code for
elements and named properties.
That seems doable. Let me do that.
https://codereview.chromium.org/934463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
