Thanks.
PTAL
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc#newcode3174
src/objects.cc:3174: NewTypeError("redefine_disallowed",
On 2015/02/18 01:26:05, adamk wrote:
On 2015/02/18 01:00:04, arv wrote:
> Maybe I should just use strict_read_only_property here as well?
Or just make a new RedefineNonconfigurableProperty() method and factor
the logic
out into that?
Done.
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc#newcode12880
src/objects.cc:12880: details.IsReadOnly() && details.kind() == kData)
||
On 2015/02/18 13:54:08, Toon Verwaest wrote:
On 2015/02/18 01:26:05, adamk wrote:
> I take it we don't need this !IsTheHole() check in the
DEFINE_PROPERTY case
> simply because we don't exercise that code path?
We could add a DCHECK(element->IsTheHole()) inside the branch...
Done.
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc#newcode12880
src/objects.cc:12880: details.IsReadOnly() && details.kind() == kData)
||
On 2015/02/18 13:54:08, Toon Verwaest wrote:
details.kind() == kData isn't necessary since DEFINE + !Configurable +
Accessor
is already handled above.
Done.
https://codereview.chromium.org/934463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
