comments addressed
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.cc#newcode123
src/profile-generator.cc:123: info.AddInlineFrame(script_id_, position_
+ deopt_position_.position());
On 2015/03/18 at 18:15:18, alph wrote:
Looks strange. Why do you want to add an inline frame if there's no
inlined_functions_info?
For example in case of a debug breakpoint you will see a stack where
each entry is a call-point and the top entry is the current position in
the top level function.
The same happens here. The top level frame points to the deopt point,
all other frames point to the inlined calls. So if you have no inlined
functions then you will see the only frame in the stack which points you
to the deopt location.
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.cc#newcode226
src/profile-generator.cc:226: indent + 10, "", 4, "",
info.stack[i].script_id,
On 2015/03/18 at 18:15:18, alph wrote:
4, ""
why?
it is an indent for inlined function stack entries. See sample.
1 test 30 #3
;;; deopted at script_id: 29 position: 45 with reason
'not a heap number'.
;;; Inline point: script_id 30 position: 36.
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.h#newcode40
src/profile-generator.h:40: struct DeoptInfo {
On 2015/03/18 at 18:15:19, alph wrote:
turn it into a class?
done
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.h#newcode90
src/profile-generator.h:90: DeoptInfo GetDeoptInfo();
On 2015/03/18 at 18:15:19, alph wrote:
seems to be quite a big object to return by value
done
https://codereview.chromium.org/1013143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
