comments addressed
https://codereview.chromium.org/1013143003/diff/130001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/1013143003/diff/130001/src/compiler.h#newcode468
src/compiler.h:468: std::vector<InlinedFunctionInfo>*
inlined_function_infos_;
On 2015/03/20 at 08:28:42, alph wrote:
why not using a smart pointer?
done
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.cc#newcode232
src/profile-generator.cc:232: for (size_t i = 1; i < info->stack.size();
++i) {
On 2015/03/20 at 08:28:42, alph wrote:
could you please use a distinct variable for inner loop iterator.
done
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.h#newcode151
src/profile-generator.h:151: std::vector<InlinedFunctionInfo>*
inlined_function_infos_;
On 2015/03/20 at 08:28:43, alph wrote:
ditto
done
https://codereview.chromium.org/1013143003/diff/130001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/1013143003/diff/130001/test/cctest/test-cpu-profiler.cc#newcode1859
test/cctest/test-cpu-profiler.cc:1859: //
0.........1.........2.........3.........4.........5.........6.........7
On 2015/03/20 at 08:28:43, alph wrote:
nit: shifted a bit
done
https://codereview.chromium.org/1013143003/diff/130001/test/cctest/test-cpu-profiler.cc#newcode1927
test/cctest/test-cpu-profiler.cc:1927: //
0.........1.........2.........3.........4.........5.........6.........7
On 2015/03/20 at 08:28:43, alph wrote:
ditto
done
https://codereview.chromium.org/1013143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
