thanks for the look (I have some questions in here)
https://codereview.chromium.org/1027283004/diff/530001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1027283004/diff/530001/src/builtins.cc#newcode1019
src/builtins.cc:1019: NewTypeError("strict_poison_pill",
HandleVector<Object>(NULL, 0)));
On 2015/04/07 16:18:39, arv wrote:
maybe rename the message key now that we renamed the functions?
Acknowledged.
https://codereview.chromium.org/1027283004/diff/530001/src/contexts.h
File src/contexts.h (right):
https://codereview.chromium.org/1027283004/diff/530001/src/contexts.h#newcode594
src/contexts.h:594: : is_strict(language_mode) ||
!IsAccessorFunction(kind)
On 2015/04/07 16:18:39, arv wrote:
I don't understand why accessor functions are special cased here?
Maybe restructure this code to make it clearer what is going on.
It was to avoid breaking the old behaviour.
But I'm not sure, it looks like lexically declared accessors are always
MethodDefinitions now, so maybe that's a break from ES5? I'm not really
sure if they should be considered "new syntactic forms" or what
https://codereview.chromium.org/1027283004/diff/530001/test/mjsunit/harmony/classes.js
File test/mjsunit/harmony/classes.js (right):
https://codereview.chromium.org/1027283004/diff/530001/test/mjsunit/harmony/classes.js#newcode923
test/mjsunit/harmony/classes.js:923: (function
testRestrictedPropertiesSloppy() {
On 2015/04/07 16:18:39, arv wrote:
Classes are always strict so I'm not sure this adds anything.
you could say it verifies the logic of the map picking in contexts.h,
and also helps verify that classes continue to be 100% strict code.
Should I toss it out?
https://codereview.chromium.org/1027283004/diff/530001/test/webkit/fast/js/Object-getOwnPropertyNames.js
File test/webkit/fast/js/Object-getOwnPropertyNames.js (right):
https://codereview.chromium.org/1027283004/diff/530001/test/webkit/fast/js/Object-getOwnPropertyNames.js#newcode63
test/webkit/fast/js/Object-getOwnPropertyNames.js:63: "parseInt":
"['arguments', 'caller', 'length', 'name']",
On 2015/04/07 16:18:40, arv wrote:
How come this still has arguments and caller?
for whatever reason, "parseInt" and "parseFloat" (and the rest of these
which still have the properties) are sloppy functions. But I guess
that's a bug.
https://codereview.chromium.org/1027283004/diff/530001/test/webkit/fast/js/caller-property-expected.txt
File test/webkit/fast/js/caller-property-expected.txt (right):
https://codereview.chromium.org/1027283004/diff/530001/test/webkit/fast/js/caller-property-expected.txt#newcode33
test/webkit/fast/js/caller-property-expected.txt:33: FAIL
nonStrictCaller(strictCallee) should throw TypeError: Type error. Threw
exception TypeError: 'caller' and 'arguments' are restricted function
properties and cannot be accessed in this context..
On 2015/04/07 16:18:40, arv wrote:
Maybe update the test for these?
Okay --- Is there a good reason this test is kept around? It seems
redundant, and it's no longer in blink's layout tests directory
https://codereview.chromium.org/1027283004/diff/530001/test/webkit/strict-throw-type-error.js
File test/webkit/strict-throw-type-error.js (right):
https://codereview.chromium.org/1027283004/diff/530001/test/webkit/strict-throw-type-error.js#newcode29
test/webkit/strict-throw-type-error.js:29:
Object.getOwnPropertyDescriptor(object, name).get;
On 2015/04/07 16:18:40, arv wrote:
This test is broken. getter always returns undefined and undefined ===
undefined
:-)
Consider deleting this test.
Acknowledged.
https://codereview.chromium.org/1027283004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
