looking good, just nits
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.cc
File src/heap/identity-map.cc (right):
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.cc#newcode50
src/heap/identity-map.cc:50: Resize(); // Should only have to resize
once, since we grow 4x.
Let's assert that we just resize once.
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc
File src/heap/identity-map.cc (right):
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc#newcode40
src/heap/identity-map.cc:40: CHECK_NE(0, raw_address); // cannot store
Smi 0 as a key here, sorry.
Cannot
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc#newcode70
src/heap/identity-map.cc:70: if (--limit == 0) break; // searched too
far; resize to insert.
Searched
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc#newcode72
src/heap/identity-map.cc:72: Resize(); // Should only have to resize
once, since we grow 4x.
4 = kResizeFactor
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc#newcode129
src/heap/identity-map.cc:129: void IdentityMapBase::Rehash() {
Can we assert here that we have the relocation lock?
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc#newcode167
src/heap/identity-map.cc:167: size_ = size_ * 4;
4 = kResizeFactor; make this a constant
https://codereview.chromium.org/1105693002/diff/20001/test/cctest/test-identity-map.cc
File test/cctest/test-identity-map.cc (right):
https://codereview.chromium.org/1105693002/diff/20001/test/cctest/test-identity-map.cc#newcode330
test/cctest/test-identity-map.cc:330:
t.heap()->CollectGarbage(i::NEW_SPACE);
Let's also write another test where these objects are on an evacuation
candidate and get compacted.
https://codereview.chromium.org/1105693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
