On 2015/04/28 13:51:16, Erik Corry wrote:
https://codereview.chromium.org/1105693002/diff/60001/src/heap/identity-map.h
File src/heap/identity-map.h (right):
https://codereview.chromium.org/1105693002/diff/60001/src/heap/identity-map.h#newcode88
src/heap/identity-map.h:88: *(reinterpret_cast<V*>(GetEntry(key))) =
value;
This assignment takes place without holding the lock, but outside the
lock,
things can move around. You could be writing in the old version.
Similar issues with Find and Get. They are returning pointers into the
values
array, which the caller can use without holding the lock.
The values array does not contain pointers into the heap, and is not
visible to
the GC.
https://codereview.chromium.org/1105693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
