LGTM
I would also like to see some tests with template literals.
https://codereview.chromium.org/1109223004/diff/60001/test/mjsunit/strong/implicit-conversions.js
File test/mjsunit/strong/implicit-conversions.js (right):
https://codereview.chromium.org/1109223004/diff/60001/test/mjsunit/strong/implicit-conversions.js#newcode80
test/mjsunit/strong/implicit-conversions.js:80: function
add_num_strong(x, y) {
Any reason for this over add_strong?
https://codereview.chromium.org/1109223004/diff/60001/test/mjsunit/strong/implicit-conversions.js#newcode294
test/mjsunit/strong/implicit-conversions.js:294:
assertThrows(function(){func(2, "foo");}, TypeError);
Shouldn't this use a non smi?
https://codereview.chromium.org/1109223004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
