That’s what I’m saying Erik —- Implement method once, install the function on the prototypes of each TypedArray class.
It’s identical to what is spec’d, minus the base %TypedArray% class’s presence. This means, it’s trivial to move from installing the method on every class to installing the method on just the base class as an incremental fix, once the base %TypedArray% class is in the tree. > On May 6, 2015, at 10:33 PM, 'Erik Arvidsson' via v8-dev > <v8-dev@googlegroups.com> wrote: > > Sorry. I think I might have given you the wrong impression. It is fine to > land incremental improvements. Just keep in mind that these functions need to > be polymorphic over all typed arrays. > > On May 6, 2015 22:22, <caitpotte...@gmail.com > <mailto:caitpotte...@gmail.com>> wrote: > On 2015/05/07 02:19:44, dehrenberg wrote: > FWIW v3 actually works. Yay tests. I guess I'll work on getting this proto > chain > and set of methods set up properly first before trying to get this submitted > though. But really it's sorta trivial no matter what order things get done in, > it just all needs to get done. > > Or were you suggesting that as a performance thing? I don't see how it'd help > performance (unless it was different copies of the same method body, like the > current code does). If it's the same actual function identity, won't it become > one big piece of polymorphic code? (Or, if otherwise, anyone have pointers to > understand how that's implemented?) > > Not a performance thing. Just, getting it as close to the spec as possible, > without worrying about the extra prototype. It's a good compromise until the > base %TypedArray% class has landed > > https://codereview.chromium.org/1128273002/ > <https://codereview.chromium.org/1128273002/> > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com <mailto:v8-dev@googlegroups.com> > http://groups.google.com/group/v8-dev <http://groups.google.com/group/v8-dev> > ---You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com > <mailto:v8-dev%2bunsubscr...@googlegroups.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev <http://groups.google.com/group/v8-dev> > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com > <mailto:v8-dev+unsubscr...@googlegroups.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
