https://codereview.chromium.org/1146683002/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1146683002/diff/1/src/parser.h#newcode1015
src/parser.h:1015: Scope* TemporaryDeclarationScope() const {
Nit: is there a strong reason to say "Temporary" here?
https://codereview.chromium.org/1146683002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1146683002/diff/1/test/cctest/test-parsing.cc#newcode6392
test/cctest/test-parsing.cc:6392: "{var: x = 42}",
Add a test with computed property names.
https://codereview.chromium.org/1146683002/diff/1/test/cctest/test-parsing.cc#newcode6460
test/cctest/test-parsing.cc:6460: "{x : x += a}",
Add a test with method syntax, e.g. "{m() {} = 0}".
https://codereview.chromium.org/1146683002/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1146683002/diff/1/test/mjsunit/harmony/destructuring.js#newcode62
test/mjsunit/harmony/destructuring.js:62:
Nit: newline
https://codereview.chromium.org/1146683002/diff/1/test/mjsunit/harmony/destructuring.js#newcode66
test/mjsunit/harmony/destructuring.js:66: var o = { get x() {
Can we modify this test (and below) such that it also checks the order
of the calls?
https://codereview.chromium.org/1146683002/diff/1/test/mjsunit/harmony/destructuring.js#newcode220
test/mjsunit/harmony/destructuring.js:220: (function
TestTDZInIntializers() {
Add tests like
let {x, y = eval("x")} = {x:42}
let {x = () => y, y} = {y:42}; x() === 42
let {x = () => eval("y"), y} = {y:42}; x() === 42
https://codereview.chromium.org/1146683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
