Quick responses to comments (I'll address others)
https://codereview.chromium.org/1151503002/diff/1/src/pattern-rewriter.cc
File src/pattern-rewriter.cc (right):
https://codereview.chromium.org/1151503002/diff/1/src/pattern-rewriter.cc#newcode308
src/pattern-rewriter.cc:308: // array = [];
On 2015/05/20 13:58:05, arv wrote:
Lets change this to not create the array here and have the runtime
funciton
create the array. Then we do not need to add the literal_index to ast
node.
We definitely want to create an array here, to benefit from allocation
site tracking optimizations
https://codereview.chromium.org/1151503002/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1151503002/diff/1/src/preparser.h#newcode2518
src/preparser.h:2518: int literal_index =
function_state_->NextMaterializedLiteralIndex();
On 2015/05/20 13:52:25, arv wrote:
Is this going to be a problem in the case of array spread?
I don't think so - we will just have an unused literal index.
https://codereview.chromium.org/1151503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
