lgtm
The IC stuff is not my forte, obviously, but it looks like mvstanton already
signed off on that?
https://codereview.chromium.org/1135243004/diff/220001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1135243004/diff/220001/src/preparser.h#newcode344
src/preparser.h:344: DCHECK(scope_type != FUNCTION_SCOPE && scope_type
!= ARROW_SCOPE);
You can split this into two DCHECKs to make errors clearer.
https://codereview.chromium.org/1135243004/diff/220001/test/mjsunit/harmony/object-literals-super.js
File test/mjsunit/harmony/object-literals-super.js (right):
https://codereview.chromium.org/1135243004/diff/220001/test/mjsunit/harmony/object-literals-super.js#newcode136
test/mjsunit/harmony/object-literals-super.js:136: (function
TestSuperPropertyInEval() {
Name is not complete: "...InEvalAndArrow", maybe?
https://codereview.chromium.org/1135243004/diff/220001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/1135243004/diff/220001/test/mjsunit/harmony/super.js#newcode2071
test/mjsunit/harmony/super.js:2071: (function TestSuperPropertyInEval()
{
Same name complaint.
https://codereview.chromium.org/1135243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
