https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc#newcode1262
src/heap/heap.cc:1262:
FragmentationOfCompactedSpacesInPercent(&total_committed);
Can we have a separate function which returns total committed compacted
space memory?
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc#newcode5450
src/heap/heap.cc:5450:
This function needs more comments about the magic that is going on here
:)
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.h#newcode1194
src/heap/heap.h:1194: return 100 - static_cast<int>(100.0 * live /
committed);
committed should never be 0 in current v8, but can we still check?
https://codereview.chromium.org/1161603006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
