Looks solid to me. A few nits and comments.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode626
src/preparser.h:626: inline void
AppendAssignmentTarget(AssignmentTargetType value) {
s/value/type/
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode2615
src/preparser.h:2615: ExpressionClassifier binding_classifier;
rename this?
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3072
src/preparser.h:3072: ParserBase<Traits>::ParseAssignmentExpression(bool
accept_IN, bool is_rhs,
TODO: Maybe add enums for this and accept_IN?
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3087
src/preparser.h:3087: bool maybeAssignmentPattern =
maybe_assignment_pattern
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3088
src/preparser.h:3088: allow_harmony_destructuring() && !is_rhs &&
maybe rename is_rhs to is_lhs?
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3144
src/preparser.h:3144: bool validDestructuringAssignmentTarget =
s/validDestructuringAssignmentTarget/valid_destructuring_assignment_target/
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6545
test/cctest/test-parsing.cc:6545: {"var x, y, z; (", " = {});"},
Do you want to do for-in and for-of too?
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6583
test/cctest/test-parsing.cc:6583: NULL};
Needs more LHS expressions.
this.x
super.x
o['x']
f().prop
(lhsExpr)
Can be done in a follow up if you want.
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6616
test/cctest/test-parsing.cc:6616: "{ x: new.target }",
I think this is valid syntax inside a function but it would throw at
runtime since it is a const binding.
https://codereview.chromium.org/1168643005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
