Indeed... looking at it closely, this must have been remnants from something I tried and then changed, but clearly not completely. Removed that entire idea (the enum, the loop, and the state moving function).
Thanks! On Tue, Jun 9, 2015 at 10:59 PM <ja...@chromium.org> wrote: > > > https://codereview.chromium.org/1157663007/diff/80001/src/compiler/register-allocator.cc > File src/compiler/register-allocator.cc (right): > > > https://codereview.chromium.org/1157663007/diff/80001/src/compiler/register-allocator.cc#newcode3227 > src/compiler/register-allocator.cc:3227 > <https://codereview.chromium.org/1157663007/diff/80001/src/compiler/register-allocator.cc#newcode3227src/compiler/register-allocator.cc:3227>: > Next(state)) { > On 2015/06/09 15:00:42, jarin wrote: > > You mean "state = Next(state)"? > > > I am puzzled why this code does not hang. > > > Also, it seems the Attempt enum is not used in any interesting way; > basically, > > it just makes the loop run two iterations in a very roundabout way. > Perhaps we > > could just have a loop from 0 to 2? > > Actually, there is a return at the end of the loop (and no continue), so > I am wondering why there is a loop at all. > > https://codereview.chromium.org/1157663007/ > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
