https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
On 2015/06/15 15:53:19, arv wrote:
This hack/workaround needs a comment.
Done.
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
On 2015/06/15 15:53:18, arv wrote:
var newIterable = {
__proto__: null,
[symbolIterator]() { return iterator; }
};
Done.
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode140
src/typedarray.js:140: for (var value of newIterable) {
On 2015/06/15 15:53:19, arv wrote:
var list = [...newIterable];
would work if we were OK with that dependency.
Would it? I thought it was important to use an InternalArray rather than
a GlobalArray.
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode159
src/typedarray.js:159: // twice. Currently, that's fine, but it'll be
observable with proxies.
On 2015/06/15 15:53:18, arv wrote:
This comment is out of date now
Deleted.
https://codereview.chromium.org/1181903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
