LGTM, mostly nits, didn't look at the serializer.
https://codereview.chromium.org/1213203007/diff/320001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/src/code-stubs.cc#newcode471
src/code-stubs.cc:471: isolate,
Handle<JSObject>(isolate->heap()->code_stub_exports_object()),
nit: Just use isolate->factory()->code_stub_exports_object() here.
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-api.cc#newcode11694
test/cctest/test-api.cc:11694: CheckSurvivingGlobalObjectsCount(1);
Can we move this off-by-one into the GetGlobalObjectsCount() helper,
together with a comment explaining why we are always seeing one global
object too many?
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-debug.cc#newcode7344
test/cctest/test-debug.cc:7344: CHECK_EQ(2, CountNativeContexts());
Same comment as in test-api.cc applies for CountNativeContexts() as
well.
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap-profiler.cc#newcode99
test/cctest/test-heap-profiler.cc:99: // The 0th-child is (GC Roots),
1st is the user root.
nit: Comment is outdated.
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1213203007/diff/320001/test/cctest/test-heap.cc#newcode1562
test/cctest/test-heap.cc:1562: CHECK_EQ(1, CountNativeContexts());
Same comment as in test-api.cc applies for CountNativeContexts() as
well.
https://codereview.chromium.org/1213203007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
