http://codereview.chromium.org/543161/diff/8002/9042 File src/mips/assembler-mips.cc (right):
http://codereview.chromium.org/543161/diff/8002/9042#newcode1234 src/mips/assembler-mips.cc:1234: // nop I think comments should be indented as well http://codereview.chromium.org/543161/diff/8002/9034 File src/mips/cpu-mips.cc (right): http://codereview.chromium.org/543161/diff/8002/9034#newcode51 src/mips/cpu-mips.cc:51: // int cacheflush(char *addr, int nbytes, int cache); nit: comment formatting http://codereview.chromium.org/543161/diff/8002/9032 File src/mips/disasm-mips.cc (right): http://codereview.chromium.org/543161/diff/8002/9032#newcode69 src/mips/disasm-mips.cc:69: #define UNSUPPORTED() printf("Unsupported instruction.\n"); PrintF? http://codereview.chromium.org/543161/diff/8002/9032#newcode758 src/mips/disasm-mips.cc:758: // int instruction_bits = *(reinterpret_cast<int*>(instruction)); remove those intstructions? http://codereview.chromium.org/543161/diff/8002/9045 File src/mips/simulator-mips.cc (right): http://codereview.chromium.org/543161/diff/8002/9045#newcode1494 src/mips/simulator-mips.cc:1494: // nit: strange comment, here and below http://codereview.chromium.org/543161/diff/8002/9029 File src/mips/virtual-frame-mips.cc (right): http://codereview.chromium.org/543161/diff/8002/9029#newcode210 src/mips/virtual-frame-mips.cc:210: return Result(); if it's valid implementation, maybe inline it? http://codereview.chromium.org/543161/diff/8002/9047 File src/mips/virtual-frame-mips.h (right): http://codereview.chromium.org/543161/diff/8002/9047#newcode250 src/mips/virtual-frame-mips.h:250: // Restore the esi register from the value of the context frame esi, ia32-ism? http://codereview.chromium.org/543161 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
