LGTM, but please, wait for Søren's blessing.
http://codereview.chromium.org/543161/diff/9055/9089 File src/mips/assembler-mips.cc (right): http://codereview.chromium.org/543161/diff/9055/9089#newcode998 src/mips/assembler-mips.cc:998: COP1 | fmt | ft.code() << 16 | fs.code() << kFsShift | cc << 8 | 3 << 4 | cond; doesn't that exceed 80 char limit? overall, ideally ./tools/presubmit.py should be run to see style violations. http://codereview.chromium.org/543161/diff/9055/9083 File src/mips/cpu-mips.cc (right): http://codereview.chromium.org/543161/diff/9055/9083#newcode51 src/mips/cpu-mips.cc:51: // See http://www.linux-mips.org/wiki/Cacheflush_Syscall comment indentation, please. http://codereview.chromium.org/543161 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
