This has been landed as r3799, see http://codereview.chromium.org/561072.
Closing this issue.
On 2010/02/04 12:11:36, Søren Gjesse wrote:
LGTM
Thank you for this patch!
I will try to land it in the repository, see
http://codereview.chromium.org/561072.
http://codereview.chromium.org/543161/diff/9055/9080
File src/mips/frames-mips.h (right):
http://codereview.chromium.org/543161/diff/9055/9080#newcode41
src/mips/frames-mips.h:41: static const RegList kJSCallerSaved =
On 2010/02/02 02:51:35, alexandre.rames wrote:
> The Register structure is declared in assembler-mips.h, and registers in
> assembler-mips.cc, so it's not very convenient.
> On 2010/02/01 22:31:23, Søren Gjesse wrote:
> > Is it possible to use the Register constants here, e.g. a0.bit()
instead
of
4.
>
>
OK
http://codereview.chromium.org/543161/diff/9055/9080#newcode57
src/mips/frames-mips.h:57: // Saved temporaries
On 2010/02/02 02:51:35, alexandre.rames wrote:
> See previous comment.
> On 2010/02/01 22:31:23, Søren Gjesse wrote:
> > Ditto.
>
>
OK
http://codereview.chromium.org/543161/diff/9055/9092
File src/mips/simulator-mips.cc (right):
http://codereview.chromium.org/543161/diff/9055/9092#newcode244
src/mips/simulator-mips.cc:244:
On 2010/02/02 02:51:35, alexandre.rames wrote:
> These are used below for formatting purpose, that's why #define
statements
are
> used. It is quite convenient. However we could still change it to static
const
> int and add some other defines or format manually below.
> (This code is nearly copied line for line form ARM code.)
> On 2010/02/01 22:31:23, Søren Gjesse wrote:
> > Please use static const int kXxxYyy for these constants.
>
>
OK
http://codereview.chromium.org/543161/diff/9055/9095
File src/mips/simulator-mips.h (right):
http://codereview.chromium.org/543161/diff/9055/9095#newcode205
src/mips/simulator-mips.h:205:
On 2010/02/02 02:51:35, alexandre.rames wrote:
> Yes it does, although I have not implemented half-word load and store
> instructions yet. (lh, lhu, sh)
> On 2010/02/01 22:31:23, Søren Gjesse wrote:
> > Does these halfword read/writes make any sense on a MIPS platform? If
not
> please
> > remove them.
>
>
Fine, we will keep them there.
http://codereview.chromium.org/543161
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
