https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc#newcode2814
test/cctest/test-heap.cc:2814: CHECK_EQ(true, heap->current_gc_flags() &
Heap::kReduceMemoryFootprintMask);
On 2015/08/20 15:52:03, Michael Starzinger wrote:
nit: Comparison of boolean with integer looks fishy. Can we use ...
CHECK_NE(0, heap->current_gc_flags() &
Heap::kReduceMemoryFootprintMask);
Done.
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc#newcode2817
test/cctest/test-heap.cc:2817: CHECK_EQ(true, heap->current_gc_flags() &
Heap::kReduceMemoryFootprintMask);
On 2015/08/20 15:52:03, Michael Starzinger wrote:
nit: Likewise.
Done.
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
