lgtm, nits attached
https://codereview.chromium.org/1301183002/diff/100001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/100001/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
We should change int flags in a follow-up cl to an enum.
https://codereview.chromium.org/1301183002/diff/100001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/100001/src/heap/heap.h#newcode2291
src/heap/heap.h:2291: // Currently set GC flags that are respected by
all components, e.g. Heap,
... all GC components.
https://codereview.chromium.org/1301183002/diff/100001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (left):
https://codereview.chromium.org/1301183002/diff/100001/src/heap/mark-compact-inl.h#oldcode21
src/heap/mark-compact-inl.h:21: DCHECK(!finalize_incremental_marking_ ||
!abort_incremental_marking_);
Bring this DCHECK back where the flags are set now.
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
