https://codereview.chromium.org/1302133002/diff/20001/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1302133002/diff/20001/src/harmony-simd.js#newcode328
src/harmony-simd.js:328: }
You should be able to "macroize" these too. Parameterize on NAME and
COUNT.
https://codereview.chromium.org/1302133002/diff/20001/src/runtime/runtime-simd.cc
File src/runtime/runtime-simd.cc (right):
https://codereview.chromium.org/1302133002/diff/20001/src/runtime/runtime-simd.cc#newcode839
src/runtime/runtime-simd.cc:839: RUNTIME_ASSERT(index >= 0);
\
Combine this with the one below, i.e. index >= 0 && ...
https://codereview.chromium.org/1302133002/diff/20001/src/runtime/runtime-simd.cc#newcode844
src/runtime/runtime-simd.cc:844: RUNTIME_ASSERT(index* bpe + bytes <=
byte_length); \
nit: space after 'index'
https://codereview.chromium.org/1302133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
