LGTM w/nits
Wait for review from Jarin and Dan
https://codereview.chromium.org/1302133002/diff/60001/src/runtime/runtime-simd.cc
File src/runtime/runtime-simd.cc (right):
https://codereview.chromium.org/1302133002/diff/60001/src/runtime/runtime-simd.cc#newcode835
src/runtime/runtime-simd.cc:835: Handle<type> result;
\
nit: move Handle declaration and combine with last line.
https://codereview.chromium.org/1302133002/diff/60001/src/runtime/runtime-simd.cc#newcode847
src/runtime/runtime-simd.cc:847: memcpy(lanes, tarray_base +
(index)*bpe, bytes); \
nit: spaces around '*' and remove parentheses.
https://codereview.chromium.org/1302133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
