+Yang for serializer/ review.
Ben: I've reworked things to have a GetDebugName on CompilerInfo. I've
replaced
all the copy/pasted code which got the debug name from the CompilerInfo
with a
call to this new function and have done a couple of other cleanups
(removing a
useless parameter on MajorName() and removing FakeStubForTesting which is no
longer required).
I've taken out all of the changes required for interpreter verification from
this CL (I'll land that as a followup) and this CL should now only be a
refactor
CL with no functional changes. PTAL, thanks.
https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc
File src/codegen.cc (right):
https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc#newcode160
src/codegen.cc:160: info->IsStub() || info->IsBytecodeHandler();
On 2015/08/21 13:37:21, titzer wrote:
Here too
Removed this (it's not about lazy deopt, so didn't replace it with
ShouldEnsureSpaceForLazyDeopt()).
https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h#newcode441
src/compiler.h:441: BYTECODE_HANDLER
On 2015/08/21 13:37:21, titzer wrote:
Do we really need a new mode? What does it control?
Removed this mode and replaced it's need with debug_name.
https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h#newcode467
src/compiler.h:467: interpreter::Bytecode bytecode_;
On 2015/08/21 13:37:21, titzer wrote:
AFAICT this is only used for debugging purposes in printing to the log
file. Can
we find another way to handle that without adding more stuff to the
(already
bloated) compilation info?
Done with GetDebugName as discussed.
https://codereview.chromium.org/1297203002/diff/60001/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):
https://codereview.chromium.org/1297203002/diff/60001/src/compiler/code-generator.cc#newcode196
src/compiler/code-generator.cc:196: if (!info->IsStub() &&
!info->IsBytecodeHandler()) {
On 2015/08/21 13:37:21, titzer wrote:
Missed this one.
Done.
https://codereview.chromium.org/1297203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
