Looks mostly good to me, I just wonder how confident we can be that using
IS_CALLABLE everywhere doesn't allow tons of cases we don't actually handle.
https://codereview.chromium.org/1316933002/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/1316933002/diff/1/src/objects-debug.cc#newcode39
src/objects-debug.cc:39: CHECK(!IsCallable());
Do we want to check this condition in more cases?
https://codereview.chromium.org/1316933002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/1316933002/diff/1/src/promise.js#newcode262
src/promise.js:262: : PromiseIdResolveHandler;
Nit: should fit one line now (same below)
https://codereview.chromium.org/1316933002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/1316933002/diff/1/src/runtime/runtime-classes.cc#newcode107
src/runtime/runtime-classes.cc:107: } else if
(super_class->IsJSFunction()) {
Shouldn't this be IsCallable as well? It's perfectly legal to inherit
from, say, a function proxy.
https://codereview.chromium.org/1316933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
