Hey, can folks take another look at this? I need someone to review the new
AST
node added to simplify some stuff.
This now works with lazy parsing for both regular functions and arrows, so
that's pretty cool.
Summary of changes:
- New AST node for rest parameters, to make literal reindexing work better
without (further) breaking the const-correctness of the existing code
(Also allows some cleanup to various is_simple_parameter tests which
also
check `is_rest` in addition to IsVariableProxy())`
- Some hacks to ensure materialized literal counts from the formals are
included in the function during creation when lazily parsed (this was not
happening before, which seems weird since it would have been needed
previously for the old binding pattern code?)
- Adds some code to enable the preparser to figure out that an arrow
function
has a rest parameter (also necessary for lazily parsing arrow functions)
There's probably some other bits, and maybe some cleanup to be done as
well. I'd
appreciate a look =)
https://codereview.chromium.org/1272673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
