LGTM on TurboFan, only nits, didn't look at the rest.
https://codereview.chromium.org/1321993004/diff/60001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1321993004/diff/60001/src/ast.h#newcode1510
src/ast.h:1510: // Expression* setter;
nit: Still look like a left-over.
https://codereview.chromium.org/1321993004/diff/60001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1321993004/diff/60001/src/compiler/ast-graph-builder.cc#newcode1900
src/compiler/ast-graph-builder.cc:1900: if (property == NULL) {
nit: s/NULL/nullptr/
https://codereview.chromium.org/1321993004/diff/60001/src/compiler/ast-graph-builder.cc#newcode1901
src/compiler/ast-graph-builder.cc:1901: VisitForValueOrNull(NULL);
nit: s/NULL/nullptr/
https://codereview.chromium.org/1321993004/diff/60001/src/compiler/ast-graph-builder.cc#newcode1904
src/compiler/ast-graph-builder.cc:1904: VisitForValueOrNull(value);
nit: Just inline "VisitForValueOrNull(property->value())" here.
https://codereview.chromium.org/1321993004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
