Doesn't merge right now, I think due to some merge artifacts (I added two
comments).


https://codereview.chromium.org/1309243003/diff/1/src/debug/liveedit.js
File src/debug/liveedit.js (right):

https://codereview.chromium.org/1309243003/diff/1/src/debug/liveedit.js#newcode219
src/debug/liveedit.js:219: for (var j = 0; j <
update_positions_list[i].live_shared_function_infos.length; j++) {
Did you change this on purpose? Seems unrelated to your fix.

https://codereview.chromium.org/1309243003/diff/1/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/1309243003/diff/1/src/object-observe.js#newcode696
src/object-observe.js:696: for (var i = 0; i <
$observeObjectMethods.length; i++)
I presume these are accidental changes?

https://codereview.chromium.org/1309243003/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to