On 2015/09/08 at 20:43:45, aperez wrote:
On 2015/09/08 07:10:34, cbruni wrote:
> Doesn't merge right now, I think due to some merge artifacts (I added
two
> comments).
Right, I am going to rebase the patch, upload a CL with the rebase.
Then I'll go through the suggested changes and upload a new CL just
with that, to make it easier to review.
> https://codereview.chromium.org/1309243003/diff/1/src/debug/liveedit.js
> File src/debug/liveedit.js (right):
>
>
https://codereview.chromium.org/1309243003/diff/1/src/debug/liveedit.js#newcode219
> src/debug/liveedit.js:219: for (var j = 0; j <
> update_positions_list[i].live_shared_function_infos.length; j++) {
> Did you change this on purpose? Seems unrelated to your fix.
This was on purpose. Not doing it would make the bootstrapper raise
an exception and mksnapshot would not finish correctly. I'see if we
can avoid the change once the code is uses a macro like you suggest.
oh ok didn't get so far ;)
Nice test coverage BTW.
I'll be happy to have a look at it again.
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
