PTAL
https://codereview.chromium.org/1316213008/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1316213008/diff/60001/src/objects.cc#newcode6561
src/objects.cc:6561: if (length_ * count < 100) return;
I tried a bit with different values and 100 turned out to be roughly
ok...
https://codereview.chromium.org/1316213008/diff/60001/src/objects.cc#newcode6562
src/objects.cc:6562: set_ = ObjectHashTable::New(isolate_, length_);
Technically this should be a set but we only have a reasonable dict
implementation. So we waste a bit of memory here in the case we fall
back to dict.
https://codereview.chromium.org/1316213008/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1316213008/diff/80001/src/objects.cc#newcode6561
src/objects.cc:6561: if (length_ * count < 100) return;
I tried a bit with different values and 100 turned out to be roughly
ok...
https://codereview.chromium.org/1316213008/diff/80001/src/objects.cc#newcode6562
src/objects.cc:6562: set_ = ObjectHashTable::New(isolate_, length_);
Technically this should be a set but we only have a reasonable dict
implementation. So we waste a bit of memory here in the case we fall
back to dict.
https://codereview.chromium.org/1316213008/diff/80001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/1316213008/diff/80001/src/runtime/runtime-array.cc#newcode201
src/runtime/runtime-array.cc:201: if
(!array->elements()->IsDictionary()) {
Early return..
https://codereview.chromium.org/1316213008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
