adressed your feedback
https://codereview.chromium.org/1316213008/diff/140001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1316213008/diff/140001/src/elements.cc#newcode876
src/elements.cc:876: virtual void
AddElementsToFixedArrayWithAccumulator(
On 2015/09/17 at 09:55:12, Igor Sheludko wrote:
WDYT about AddElementsToKeyAccumulator() name?
Indeed better choice.
https://codereview.chromium.org/1316213008/diff/140001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1316213008/diff/140001/src/objects.cc#newcode6736
src/objects.cc:6736: FixedArray::NON_SYMBOL_KEYS);
On 2015/09/17 at 09:55:12, Igor Sheludko wrote:
Why do you use a different filter than in the old code?
my mistake :)
https://codereview.chromium.org/1316213008/diff/140001/src/objects.cc#newcode15432
src/objects.cc:15432: Isolate* isolate = table->GetIsolate();
On 2015/09/17 at 09:55:12, Igor Sheludko wrote:
Spurious change.
reverted
https://codereview.chromium.org/1316213008/diff/140001/src/objects.cc#newcode15447
src/objects.cc:15447: Isolate* isolate = table->GetIsolate();
On 2015/09/17 at 09:55:12, Igor Sheludko wrote:
Spurious change.
reverted
https://codereview.chromium.org/1316213008/diff/140001/src/objects.cc#newcode15659
src/objects.cc:15659: table->set(new_index + 1,
Smi::FromInt(previous_entry));
On 2015/09/17 at 09:55:12, Igor Sheludko wrote:
I think "+ kChainOffset" is better than "+ 1" for readability.
indeed
https://codereview.chromium.org/1316213008/diff/140001/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):
https://codereview.chromium.org/1316213008/diff/140001/src/runtime/runtime-object.cc#newcode1005
src/runtime/runtime-object.cc:1005: for (int i = offset - 100; i <
offset && i < length; i++) {
On 2015/09/17 at 09:55:12, Igor Sheludko wrote:
...; i < end; ...
updated
https://codereview.chromium.org/1316213008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
