https://codereview.chromium.org/988893003/diff/280001/include/v8-platform.h
File include/v8-platform.h (right):
https://codereview.chromium.org/988893003/diff/280001/include/v8-platform.h#newcode126
include/v8-platform.h:126: const char* name, uint64_t handle) = 0;
These really need elucidating comments, either inline or as links to
online or in-repo documentation.
Style issue: I think V8 prefers snake_case over camelCase, i.e.,
category_enabled_flag instead of categoryEnabledFlag.
https://codereview.chromium.org/988893003/diff/280001/src/libplatform/default-platform.cc
File src/libplatform/default-platform.cc (right):
https://codereview.chromium.org/988893003/diff/280001/src/libplatform/default-platform.cc#newcode190
src/libplatform/default-platform.cc:190: static const char* dummy =
"dummy";
`static const char[] dummy = ...`?
https://codereview.chromium.org/988893003/diff/280001/src/log-inl.h
File src/log-inl.h (right):
https://codereview.chromium.org/988893003/diff/280001/src/log-inl.h#newcode42
src/log-inl.h:42: TRACE_EVENT_END_WITH_CONTEXT_ID0("v8", name,
(uint64_t)isolate);
Style: use static_cast/reinterpret_cast here.
Should this block be hoisted to one of the outer if statements? It
currently isn't reached when logging is disabled.
https://codereview.chromium.org/988893003/diff/280001/test/cctest/test-trace-event.cc
File test/cctest/test-trace-event.cc (right):
https://codereview.chromium.org/988893003/diff/280001/test/cctest/test-trace-event.cc#newcode29
test/cctest/test-trace-event.cc:29: int numArgs;
Style nit: mildly inconsistent mix of camelCase and snake_case.
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
