LGTM with comments.
I think I'm missing a test case where we can distinguish trace events by
isolate
(using the isolate as id?).
https://codereview.chromium.org/988893003/diff/320001/include/v8-platform.h
File include/v8-platform.h (right):
https://codereview.chromium.org/988893003/diff/320001/include/v8-platform.h#newcode125
include/v8-platform.h:125: * Add a trace event to the platform tracing
system.
Can you add a comment about what this method returns? It seems unclear
to me.
https://codereview.chromium.org/988893003/diff/320001/src/tracing/trace-event.h
File src/tracing/trace-event.h (right):
https://codereview.chromium.org/988893003/diff/320001/src/tracing/trace-event.h#newcode276
src/tracing/trace-event.h:276: class TraceID {
Is this ID used to represent the isolate? If yes, then adding all the
different flavors of DontMangle and ForceMangle seems a bit overkill if
we are only going to use DontMangle(const void*).
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
