LGTM On Mon, Apr 1, 2019 at 12:13 PM Sathya Gunasekaran <gsat...@chromium.org> wrote:
> > > On Fri, Mar 29, 2019 at 7:41 AM Frank Tang <ft...@chromium.org> wrote: > >> Spec >> >> https://github.com/tc39/proposal-intl-datetime-style/ >> >> Summary >> >> A Stage 3 proposal that adds two options to Intl.DateTimeFormat: >> dateStyle and timeStyle. These options give a compact way to request the >> appropriate, locale-specific way to ask for a date and time of given lengths >> Example >> >> let o = new Intl.DateTimeFormat("en" , { >> timeStyle: "short" >> });console.log(o.format(Date.now())); // "13:31" >> let o = new Intl.DateTimeFormat("en" , { >> dateStyle: "short" >> });console.log(o.format(Date.now())); // "21.03.2012" >> let o = new Intl.DateTimeFormat("en" , { >> timeStyle: "medium", >> dateStyle: "short" >> });console.log(o.format(Date.now())); // "21.03.2012, 13:31" >> >> >> >> Interoperability and compatibility risk >> >> The two new options added to Intl.DateTimeFormat is new and should have >> no risk to break pre-existing javascript code. >> >> - >> >> Firefox:Public support >> <https://bugzilla.mozilla.org/show_bug.cgi?id=1329904> >> - >> >> Edge: No public signals >> - >> >> Safari:No public signals >> - >> >> Web Developers:No signals >> >> >> Is this feature fully tested? >> >> Yes; our implementation passes our own V8 tests for all the features. >> >> test/intl/date-format/constructor-date-time-style.js >> test/intl/date-format/constructor-date-time-style-order.js >> test/intl/date-format/property-override-date-time-style.js >> test/intl/date-format/constructor-date-style-order.js >> test/intl/date-format/property-override-date-style.js >> test/intl/date-format/constructor-time-style-order.js >> test/intl/date-format/property-override-time-style.js >> >> > What about test262 tests? > Test262 tests for this has landed and V8 passes all of them: https://chromium.googlesource.com/v8/v8/+/96c1a8835f04859fccf1d183c0f545cab7affe1d# > > >> Tracking bug >> >> https://crbug.com/v8/8702 >> >> >> Design Doc: >> >> https://goo.gl/v7n7zV >> >> >> Link to entry on the Chrome Platform Status dashboard >> >> https://www.chromestatus.com/features/5091631933947904 >> >> >> >> Requesting approval to ship? >> >> Yes. Note that since this is a V8/JS feature, this post is just an FYI to >> blink-dev — no signoff from Blink API owners is required. >> > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
