Adding ModuleNamespaceEntryGetter to the macro sounds reasonable to me. Igor, are you aware of any reason why that getter would need special-casing?
On Fri, Aug 26, 2022 at 5:30 AM Giovanny Gutierrez < giovannygutier...@gmail.com> wrote: > I was trying to create a snapshot of a code using modules, and started to > get an issue about "Unknown external reference" . After debugging the code > I realized it was on Accessors::ModuleNamespaceEntryGetter and reviewing > the code this is the only one not defined through the ` > ACCESSOR_GETTER_DECLARATION` macro, therefore was not included in the > external reference table, through the ExternalReferenceTable::AddAccessors > function, was there any other reason to not include the > ModuleNamespaceEntryGetter in the ReferenceTable list? Can I send a PR to > add it manually? or is there a better way to include this function in the > ExternalReferenceTable? > > Here's the portion of the code I'm referring to > > accessors.h > <https://github.com/v8/v8/blob/main/src/builtins/accessors.h#L93-L96> > external-reference-table.ccc > <https://github.com/v8/v8/blob/main/src/codegen/external-reference-table.cc#L234-L259> > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/90aed667-8c2f-45fd-bb53-ef54dbeb7d7bn%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/90aed667-8c2f-45fd-bb53-ef54dbeb7d7bn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3QNLFjAwk%3DKYCoaRwQKWWD7J-0_VF9iqTQu-b2hNSAcVw%40mail.gmail.com.
