Hi, First of all, a small detail here that might be important: The --turboshaft flag (enabled by default) runs the a large section of the compilation pipeline (up to, but excluding instruction selection) using the new Turboshaft infrastructure. In order to run instruction selection on the Turboshaft CFG produced by the pipeline, the --turboshaft-instruction-selection flag (also enabled by default now) must be set. Otherwise we convert back to the old TurboFan sea-of-nodes graph and select on this. We will drop this fallback solution in the near future, though.
Now, when it comes to the instruction selector unit tests, those cannot just be flipped by providing those flags as they are specifically built for TurboFan. Those need some adjustment to run with the Turboshaft instruction selection. For an example see the port of the x64 unit tests in turboshaft-instruction-selector-x64-unittest.cc. Hope that helps, Nico On Thu, May 30, 2024 at 11:27 AM yahan lu <luyahan...@gmail.com> wrote: > I think i should port turboshaft-instruction-selector-unittest into > instruction-selector-xxx-unittests > > 在2024年5月30日星期四 UTC+8 17:16:14<yahan lu> 写道： > >> ``` >> DEFINE_BOOL(turboshaft, true, "enable TurboFan's Turboshaft phases for >> JS") >> ``` >> v8 enbale turboshaft. But don't run instruction-selector test in >> turboshaft mode >> 在2024年5月30日星期四 UTC+8 17:07:07<yahan lu> 写道： >> >>> I want to run instruction-selector-riscv64-unittest in turboshaft. >>> >>> -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/b1c016e8-fc94-4967-a95c-21b1b916707en%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/b1c016e8-fc94-4967-a95c-21b1b916707en%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Nico Hartmann | Software Engineer | nicohartm...@google.com | Chrome - V8 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAHNjccKpciJ_f55jPovL8SnQhyNonyWjWzAW%3D1VFqsxBucy%3DxQ%40mail.gmail.com.
