Hi there, Nico and Matthias said it all already pretty much, but, for completeness and to give an example, here are the CLs that ported the x64 instruction selector unit tests: - https://chromium-review.googlesource.com/c/v8/v8/+/5368860 - https://chromium-review.googlesource.com/c/v8/v8/+/5372724 - https://chromium-review.googlesource.com/c/v8/v8/+/5383047
Cheers, Darius On Monday, June 3, 2024 at 7:16:18 AM UTC+2 Matthias Liedtke wrote: > Hi, > > I think you'll have to copy it over into a new file, then > replace InstructionSelectorTestWithParam with > TurboshaftInstructionSelectorTestWithParam and adapt all the graph building > blocks with their turboshaft equivalents. > Darius has done some prior work here and ported most of the x64 > unittests which should give a good overview on this. > > Best regards, > Matthias > > On Thu, May 30, 2024 at 11:27 AM yahan lu <luyah...@gmail.com> wrote: > >> I think i should port turboshaft-instruction-selector-unittest into >> instruction-selector-xxx-unittests >> >> 在2024年5月30日星期四 UTC+8 17:16:14<yahan lu> 写道： >> >>> ``` >>> DEFINE_BOOL(turboshaft, true, "enable TurboFan's Turboshaft phases for >>> JS") >>> ``` >>> v8 enbale turboshaft. But don't run instruction-selector test in >>> turboshaft mode >>> 在2024年5月30日星期四 UTC+8 17:07:07<yahan lu> 写道： >>> >>>> I want to run instruction-selector-riscv64-unittest in turboshaft. >>>> >>>> -- >> -- >> v8-dev mailing list >> v8-...@googlegroups.com >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-dev+un...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-dev/b1c016e8-fc94-4967-a95c-21b1b916707en%40googlegroups.com >> >> <https://groups.google.com/d/msgid/v8-dev/b1c016e8-fc94-4967-a95c-21b1b916707en%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/921341f5-a33e-4c06-acda-9c2b9c1cd40cn%40googlegroups.com.
