I was implementing the cppgc into my project and found that the CppHeap::Create returns a unique ptr where as the CreateParams.cpp_heap is just a pointer leading to having to get the pointer from the unique and then releasing when setting the param. Considering it's now the preferred way to set an embedder cppgc heap maybe the create params should be made a unique ptr as well.
-- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/fa2f1dbf-b07c-4f10-8198-1929bb74824fn%40googlegroups.com.
