Addressed the comments. Added AssertNoGC class to prohibit GC while the stubs are being compiled.
http://codereview.chromium.org/3047027/diff/1/2 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/3047027/diff/1/2#newcode1258 src/arm/stub-cache-arm.cc:1258: __ Jump(Handle<Code>(Code::cast(code)), RelocInfo::CODE_TARGET); On 2010/07/30 13:48:25, antonm wrote:
stylistic nit: maybe negative check:
if (!code->IsCode) return code;
or even if (code->IsFailure()) return code;
?
And maybe code should be renamed into something like result.
Feel free to ignore.
Done. http://codereview.chromium.org/3047027/diff/1/2#newcode1292 src/arm/stub-cache-arm.cc:1292: Object* branch = GenerateMissBranch(); On 2010/07/30 13:33:34, Vitaly wrote:
Well, the generator function doesn't return the branch code (in fact,
it really
can't since the branch is part of the current code object). The
contract here is
that if it returned a failure, it must be propagated. Something like
this:
Object* obj = GenerateMissBranch(); if (obj->IsFailure()) return obj;
Done. http://codereview.chromium.org/3047027/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
