Reviewers: Søren Gjesse,

Description:
Enhance SafeStackFrameIterator to avoid triggering assertions in debug mode.

When running profiling in debug mode, several assertions in frame
iterators that are undoubtedly useful when iterator is started from a
VM thread in a known "good" state, may fail when running over a stack
of a suspended VM thread. This patch makes SafeStackFrameIterator
to proactively check addresses and bail out from iteration early,
before an assertion will be triggered.

BUG=crbug/55565

Please review this at http://codereview.chromium.org/3436006/show

Affected files:
  M src/arm/frames-arm.cc
  M src/frames.h
  M src/frames.cc
  M src/ia32/frames-ia32.cc
  M src/log.cc
  M src/mips/frames-mips.cc
  M src/x64/frames-x64.cc
  M test/cctest/test-log-stack-tracer.cc


--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to