Still LGTM
http://codereview.chromium.org/4117010/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/4117010/diff/1/2#newcode1798 include/v8.h:1798: inline Arguments(internal::Object** extra, On 2010/11/01 08:54:58, SeRya wrote:
On 2010/10/29 19:00:27, antonm wrote: > any chances for better names? for example args might be a better
name for
> values, but alas I don't have any good idea for extra.
'args' would sould like tautology for me (the class itself is named
Arguments).
'extra' I renamed to 'implicit_args'. Does it sound good for you?
Yes, implicit_args sounds really nice, thank you. http://codereview.chromium.org/4117010/diff/14001/15002 File src/apiutils.h (right): http://codereview.chromium.org/4117010/diff/14001/15002#newcode47 src/apiutils.h:47: // Packs additional parameters for the NewArguments function. 'data' is should 'data' here be changed to |implicit_args|? Note, that names of arguments/vars are usually placed into || in docs. http://codereview.chromium.org/4117010/diff/14001/15003 File src/arguments.h (right): http://codereview.chromium.org/4117010/diff/14001/15003#newcode88 src/arguments.h:88: inline CustomArguments() { maybe kZapValue value_ in debug mode? http://codereview.chromium.org/4117010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
