LGTM On Mon, Nov 1, 2010 at 1:32 PM, <[email protected]> wrote: > > http://codereview.chromium.org/4117010/diff/14001/15002 > File src/apiutils.h (right): > > http://codereview.chromium.org/4117010/diff/14001/15002#newcode47 > src/apiutils.h:47: // Packs additional parameters for the NewArguments > function. 'data' is > On 2010/11/01 09:32:34, antonm wrote: >> >> should 'data' here be changed to |implicit_args|? Note, that names of >> arguments/vars are usually placed into || in docs. > > Done. > > http://codereview.chromium.org/4117010/diff/14001/15003 > File src/arguments.h (right): > > http://codereview.chromium.org/4117010/diff/14001/15003#newcode88 > src/arguments.h:88: inline CustomArguments() { > On 2010/11/01 09:32:34, antonm wrote: >> >> maybe kZapValue value_ in debug mode? > > Done. > > http://codereview.chromium.org/4117010/show >
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
