drive by comments.
http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h#newcode585 src/arm/macro-assembler-arm.h:585: void VFPCompareAndSetFlags(const DwVfpRegister src1, Since the instruction sets the flags, the s parameter is meaningless. In fact the s parameter in the vcmp instruction is also superfluous and probably should be removed, it is not present in the instruction encoding. http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h#newcode590 src/arm/macro-assembler-arm.h:590: vmrs(pc); vmrs should be conditional too. http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h#newcode592 src/arm/macro-assembler-arm.h:592: void VFPCompareAndSetFlags(const DwVfpRegister src1, As above. http://codereview.chromium.org/6117003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
